Rollup of 11 pull requests#150839
Conversation
Define a new function ensure_version which is extracted (and modified) from ensure_version_or_cargo_install.
for other extra checks, it is WIP.
This updates the rust-version file to 23d01cd.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: 23d01cd Filtered ref: 5d28c73d267214190903896b4caf2e40a17a56cb Upstream diff: rust-lang/rust@2dc3024...23d01cd This merge was created using https://github.com/rust-lang/josh-sync.
…emove unsafe from usages" We can't drop the `unsafe` here because it is required at the `libm` MSRV. Instead, we will need to `allow` the lint. This reverts commit 96ac3624abc144db930d94504a9c67aad7b949ed.
- Implement basic opening and creating files. - Also implement debug. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Make it easier to run the same steps outside of GitHub Actions.
- Using the implementation from sys::fs::common since UEFI does not have a built-in for this functionality. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Similarly to i686 and X86_64 MinGW targets, Rust needs to provide the right chkstk symbol for AArch64 to avoid relying on the linker to provide it. CC rust-lang#150725
This commit moves a query to `associated_item_defs` from above an error condition caused independently of it to below it. It looks generally cleaner and might potentially save some runtime in case the error condition is met, rendering `items` to be left unused, yet still queried.
…k, r=lolbinarycat tidy: add if-installed prefix condition to extra checks system Ref: https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Should.20Spellcheck.20check.20all.20files.3F/with/543227610 tidy now runs spellcheck (typos-cli) without adding `--extra-checks=spellcheck` option if the tool is already installed under ./build/misc-tools and the version is expected. It will improve code quality without bothering engineers who doesn't want to use typos or who cleans up ./build directory frequently.
std: sys: fs: uefi: Implement initial File - Implement basic opening and creating files. - Also implement debug. @rustbot label +O-UEFI
std: sys: fs: uefi: Implement remove_dir_all - Using the implementation from sys::fs::common since UEFI does not have a built-in for this functionality. @rustbot label +O-UEFI
|
@bors r+ rollup=never p=5 |
|
@bors try=dist-ohos-x86_64 |
|
Unknown command "try". Run |
|
@bors try jobs=dist-ohos-x86_64 |
This comment has been minimized.
This comment has been minimized.
Rollup of 11 pull requests try-job: dist-ohos-x86_64
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 31cd367 (parent) -> 3fda0e4 (this PR) Test differencesShow 42 test diffsStage 0
Stage 1
Stage 2
Additionally, 36 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 3fda0e426ca17b0baa0d6e765a0d23f487350573 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 31cd367b9c In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (3fda0e4): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 0.1%, secondary -2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 474.812s -> 474.629s (-0.04%) |
Successful merges:
std::os::fd::owned#150549 (fix missing_panics_doc instd::os::fd::owned)literal-escaperversion to0.0.7#150809 (Updateliteral-escaperversion to0.0.7)r? @ghost
Create a similar rollup